Skip to content

Conversation

apricote
Copy link
Member

@apricote apricote commented Aug 7, 2025

We collect all changes for the Storage Box support (#1117) in this PR. It will only be merged when everything is implemented through smaller pull requests targeting the storage-boxes branch.

Closes #1117

@apricote apricote mentioned this pull request Aug 7, 2025
11 tasks
Copy link

codecov bot commented Aug 7, 2025

Codecov Report

❌ Patch coverage is 69.82036% with 252 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.61%. Comparing base (c35b0c9) to head (af147d8).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/cmd/storagebox/create.go 72.30% 25 Missing and 11 partials ⚠️
internal/cmd/storagebox/change_type.go 55.31% 14 Missing and 7 partials ⚠️
internal/cmd/storagebox/enable_protection.go 68.25% 14 Missing and 6 partials ⚠️
internal/cmd/storagebox/enable_snapshot_plan.go 76.00% 12 Missing and 6 partials ⚠️
internal/cmd/storagebox/rollback_snapshot.go 60.00% 12 Missing and 6 partials ⚠️
internal/cmd/storagebox/snapshot/create.go 65.38% 12 Missing and 6 partials ⚠️
internal/cmd/storagebox/snapshot/cmpl.go 5.55% 16 Missing and 1 partial ⚠️
internal/cmd/storagebox/folders.go 71.15% 9 Missing and 6 partials ⚠️
internal/cmd/storagebox/snapshot/labels.go 62.16% 10 Missing and 4 partials ⚠️
internal/cmd/storagebox/disable_snapshot_plan.go 61.29% 8 Missing and 4 partials ⚠️
... and 7 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1118      +/-   ##
==========================================
- Coverage   69.78%   69.61%   -0.18%     
==========================================
  Files         271      311      +40     
  Lines       12302    13989    +1687     
==========================================
+ Hits         8585     9738    +1153     
- Misses       2911     3309     +398     
- Partials      806      942     +136     
Flag Coverage Δ
e2e 49.46% <24.79%> (-2.91%) ⬇️
unit 64.27% <69.82%> (+0.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@phm07 phm07 force-pushed the storage-boxes branch 2 times, most recently from a73c39e to 2a8203f Compare September 18, 2025 10:31

accessSettings := storageBox.AccessSettings
cmd.Println("Access Settings:")
cmd.Printf(" Reachable Externally:\t\t%t\n", accessSettings.ReachableExternally)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed, should we use util.YesNo here?

@phm07 phm07 force-pushed the storage-boxes branch 2 times, most recently from b49423e to cc1cb63 Compare September 22, 2025 09:49
@phm07 phm07 force-pushed the storage-boxes branch 2 times, most recently from 9ef2c0b to 331f63c Compare October 10, 2025 14:48
apricote and others added 11 commits October 17, 2025 15:15
Adds support for the Hetzner API (`https://api.hetzner.com`) with a new
option to configure the API endpoint:

- Config Key: `hetzner-endpoint`
- Flag: `--hetzner-endpoint`
- Environment Variable: `HETZNER_ENDPOINT`

Co-authored-by: Julian Tölle <[email protected]>
Adds the CRUD commands `hcloud storage-box-type describe` and `hcloud
storage-box-type list`.

Related to #1117

---------

Co-authored-by: lukasmetzner <[email protected]>
`snapshot_limit` and `automatic_snapshot_limit` are pointers now.
This PR implements the CRUD (create, read, update, delete) operations
for Storage Boxes.

---------

Co-authored-by: lukasmetzner <[email protected]>
This PR implements actions for Storage Boxes.
This PR adds support for Storage Box Snapshots
This PR implements the Storage Box Subaccount resource.
@jooola
Copy link
Member

jooola commented Oct 17, 2025

Rebased on top of main

- Bump `hcloud-go` to latest version in branch `storage-boxes` and fix
any issues.
- Use the `default-ssh-keys` Options also for Storage Box SSH Keys.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: support for Storage Boxes

4 participants